Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2110)

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 2451523002: Insert logcat as part of test result for android instrumentation tests. (Closed)
Patch Set: change from logcat snippet to logcat url Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/instrumentation/instrumentation_test_instance.py
diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py
index f8d37e76c0223bc5b3f001268120ccd5cbca42e7..2a5125c0985e4e783fa779ae0b0c6bec417e0556 100644
--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py
+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py
@@ -442,6 +442,9 @@ class InstrumentationTestInstance(test_instance.TestInstance):
self._store_tombstones = False
self._initializeTombstonesAttributes(args)
+ self._json_results_file = None
+ self._initializeJsonResultsFileAttributes(args)
+
def _initializeApkAttributes(self, args, error_func):
if args.apk_under_test:
apk_under_test_path = args.apk_under_test
@@ -594,6 +597,9 @@ class InstrumentationTestInstance(test_instance.TestInstance):
def _initializeTombstonesAttributes(self, args):
self._store_tombstones = args.store_tombstones
+ def _initializeJsonResultsFileAttributes(self, args):
+ self._json_results_file = args.json_results_file
jbudorick 2016/11/23 16:25:21 nit: I would store this as self._should_save_logca
BigBossZhiling 2016/11/29 00:40:42 Done.
+
@property
def additional_apks(self):
return self._additional_apks
@@ -627,6 +633,10 @@ class InstrumentationTestInstance(test_instance.TestInstance):
return self._flags
@property
+ def json_results_file(self):
+ return self._json_results_file
+
+ @property
def package_info(self):
return self._package_info

Powered by Google App Engine
This is Rietveld 408576698