Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: build/android/pylib/results/json_results.py

Issue 2451523002: Insert logcat as part of test result for android instrumentation tests. (Closed)
Patch Set: added the newly added file Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/results/json_results.py
diff --git a/build/android/pylib/results/json_results.py b/build/android/pylib/results/json_results.py
index 593c67a6c3f1ebd82535d59a5b7bc8842b384bf7..10a0eae6e1c3fd89e6ef843a1700def2acd3430d 100644
--- a/build/android/pylib/results/json_results.py
+++ b/build/android/pylib/results/json_results.py
@@ -102,6 +102,7 @@ def GenerateResultsDict(test_run_results):
'losless_snippet': '',
'output_snippet_base64:': '',
'tombstones': r.GetTombstones() or '',
+ 'logcat_snippet': r.GetLogcatUrl() or '',
jbudorick 2016/11/22 14:40:15 nit: I think this should be 'logcat_url'
BigBossZhiling 2016/11/23 00:28:07 Done.
}
iteration_data[r.GetName()].append(result_dict)

Powered by Google App Engine
This is Rietveld 408576698