Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2451513002: DevTools: [Elements] account for the left indent in the width of inplace editor (Closed)

Created:
4 years, 1 month ago by lushnikov
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Elements] account for the left indent in the width of inplace editor The inplace editor's width should account for the left indent. BUG=657297 R=dgozman Committed: https://crrev.com/2de862f7214638b6bc8ccf2c672ddf32b25dc768 Cr-Commit-Position: refs/heads/master@{#427233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lushnikov
please, take a look
4 years, 1 month ago (2016-10-24 23:17:06 UTC) #1
dgozman
Nice! lgtm
4 years, 1 month ago (2016-10-24 23:46:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451513002/1
4 years, 1 month ago (2016-10-25 00:07:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 01:53:03 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 01:54:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2de862f7214638b6bc8ccf2c672ddf32b25dc768
Cr-Commit-Position: refs/heads/master@{#427233}

Powered by Google App Engine
This is Rietveld 408576698