Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2451503002: use __OPTIMIZE__ macro to determine debug vs release. (Closed)

Created:
4 years, 1 month ago by fbarchard1
Modified:
4 years, 1 month ago
Reviewers:
wangcheng
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

use __OPTIMIZE__ macro to determine debug vs release. Debug builds of x86 gcc/clang can run out of register. Previously NDEBUG or _DEBUG was used to detect a debug build. But those macros are not set by gentoo builds. This CL switches to the compiler predefine __OPTIMIZE__ which is built into clang and gcc. BUG=libyuv:602 TEST=untested R=wangcheng@google.com Committed: https://chromium.googlesource.com/libyuv/libyuv/+/c2073823b4d69652580691b73b01ed87619e20be

Patch Set 1 #

Total comments: 1

Patch Set 2 : allow clang-cl to use ssse3 version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/row.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M source/row_gcc.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
wangcheng
https://codereview.chromium.org/2451503002/diff/1/include/libyuv/row.h File include/libyuv/row.h (right): https://codereview.chromium.org/2451503002/diff/1/include/libyuv/row.h#newcode494 include/libyuv/row.h:494: #define OMITFP __attribute__((optimize("omit-frame-pointer"))) might affect the expectation of build ...
4 years, 1 month ago (2016-10-25 00:26:48 UTC) #2
wangcheng
lgtm
4 years, 1 month ago (2016-10-25 00:39:33 UTC) #3
fbarchard1
4 years, 1 month ago (2016-10-25 01:02:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c2073823b4d69652580691b73b01ed87619e20be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698