xfa/fxfa/parser/cxfa_simple_parser.cpp - Issue 2451493002: Refcount all the IFX_ stream classes all the time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/cxfa_simple_parser.cpp

Issue 2451493002: Refcount all the IFX_ stream classes all the time. (Closed)

Patch Set: Clean up cast expression Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/cxfa_simple_parser.cpp

diff --git a/xfa/fxfa/parser/cxfa_simple_parser.cpp b/xfa/fxfa/parser/cxfa_simple_parser.cpp

index a9025fa42a74777e19888bdf49f533532cebd0b7..2329e86874fd910d72ec921e57fd5a42078056b2 100644

--- a/xfa/fxfa/parser/cxfa_simple_parser.cpp

+++ b/xfa/fxfa/parser/cxfa_simple_parser.cpp

@@ -277,8 +277,9 @@ void CXFA_SimpleParser::SetFactory(CXFA_Document* pFactory) {

m_pFactory = pFactory;

}

-int32_t CXFA_SimpleParser::StartParse(IFX_SeekableReadStream* pStream,

- XFA_XDPPACKET ePacketID) {

+int32_t CXFA_SimpleParser::StartParse(

+ const CFX_RetainPtr<IFX_SeekableReadStream>& pStream,

+ XFA_XDPPACKET ePacketID) {

CloseParser();

m_pFileRead = pStream;

m_pStream.reset(IFGAS_Stream::CreateStream(

« no previous file with comments | « xfa/fxfa/parser/cxfa_simple_parser.h ('k') | xfa/fxfa/xfa_checksum.h » ('j') | no next file with comments »