Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: testing/libfuzzer/xfa_codec_fuzzer.h

Issue 2451493002: Refcount all the IFX_ stream classes all the time. (Closed)
Patch Set: Clean up cast expression Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/libfuzzer/pdf_cfx_saxreader_fuzzer.cc ('k') | xfa/fde/xml/cfx_saxreader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/libfuzzer/xfa_codec_fuzzer.h
diff --git a/testing/libfuzzer/xfa_codec_fuzzer.h b/testing/libfuzzer/xfa_codec_fuzzer.h
index 4281db0ac90b4b6ccc05e055ac0ec2be49c2878a..8608993396b0fd51fff8f6662b1454a3e3c0f43c 100644
--- a/testing/libfuzzer/xfa_codec_fuzzer.h
+++ b/testing/libfuzzer/xfa_codec_fuzzer.h
@@ -17,10 +17,8 @@ class XFACodecFuzzer {
std::unique_ptr<CCodec_ModuleMgr> mgr(new CCodec_ModuleMgr());
std::unique_ptr<CCodec_ProgressiveDecoder> decoder(
mgr->CreateProgressiveDecoder());
- Reader source(data, size);
-
- FXCODEC_STATUS status =
- decoder->LoadImageInfo(&source, type, nullptr, true);
+ CFX_RetainPtr<Reader> source(new Reader(data, size));
+ FXCODEC_STATUS status = decoder->LoadImageInfo(source, type, nullptr, true);
if (status != FXCODEC_STATUS_FRAME_READY)
return 0;
@@ -46,8 +44,6 @@ class XFACodecFuzzer {
Reader(const uint8_t* data, size_t size) : m_data(data), m_size(size) {}
~Reader() {}
- void Release() override {}
-
bool ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) override {
if (offset < 0 || static_cast<size_t>(offset) >= m_size)
return false;
« no previous file with comments | « testing/libfuzzer/pdf_cfx_saxreader_fuzzer.cc ('k') | xfa/fde/xml/cfx_saxreader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698