fpdfsdk/fpdfxfa/cpdfxfa_context.cpp - Issue 2451493002: Refcount all the IFX_ stream classes all the time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfxfa/cpdfxfa_context.cpp

Issue 2451493002: Refcount all the IFX_ stream classes all the time. (Closed)

Patch Set: Clean up cast expression Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfxfa/cpdfxfa_context.cpp

diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_context.cpp b/fpdfsdk/fpdfxfa/cpdfxfa_context.cpp

index 7945786070718f16ef9b4a420554fc159af922fd..1995882388b457364d0c281501b4e62c34f91901 100644

--- a/fpdfsdk/fpdfxfa/cpdfxfa_context.cpp

+++ b/fpdfsdk/fpdfxfa/cpdfxfa_context.cpp

@@ -328,7 +328,7 @@ CFX_WideString CPDFXFA_Context::Response(const CFX_WideString& wsQuestion,

return wsAnswer;

}

-IFX_SeekableReadStream* CPDFXFA_Context::DownloadURL(

+CFX_RetainPtr<IFX_SeekableReadStream> CPDFXFA_Context::DownloadURL(

const CFX_WideString& wsURL) {

return m_pFormFillEnv ? m_pFormFillEnv->DownloadFromURL(wsURL.c_str())

: nullptr;

« no previous file with comments | « fpdfsdk/fpdfxfa/cpdfxfa_context.h ('k') | fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h » ('j') | no next file with comments »