fpdfsdk/fpdfeditimg.cpp - Issue 2451493002: Refcount all the IFX_ stream classes all the time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfeditimg.cpp

Issue 2451493002: Refcount all the IFX_ stream classes all the time. (Closed)

Patch Set: Clean up cast expression Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfeditimg.cpp

diff --git a/fpdfsdk/fpdfeditimg.cpp b/fpdfsdk/fpdfeditimg.cpp

index 2c869ac624c83c7842c02d25395956d2a3a6755d..531a9abc8c9debe6157448cd7b5608dc2856e197 100644

--- a/fpdfsdk/fpdfeditimg.cpp

+++ b/fpdfsdk/fpdfeditimg.cpp

@@ -32,7 +32,8 @@ FPDFImageObj_LoadJpegFile(FPDF_PAGE* pages,

if (!image_object || !fileAccess || !pages)

return false;

- IFX_SeekableReadStream* pFile = MakeSeekableReadStream(fileAccess);

+ CFX_RetainPtr<IFX_SeekableReadStream> pFile =

+ MakeSeekableReadStream(fileAccess);

CPDF_ImageObject* pImgObj = reinterpret_cast<CPDF_ImageObject*>(image_object);

for (int index = 0; index < nCount; index++) {

CPDF_Page* pPage = CPDFPageFromFPDFPage(pages[index]);

« no previous file with comments | « fpdfsdk/fpdf_dataavail.cpp ('k') | fpdfsdk/fpdfsave.cpp » ('j') | no next file with comments »