core/fxge/android/cfpf_skiafontmgr.h - Issue 2451493002: Refcount all the IFX_ stream classes all the time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxge/android/cfpf_skiafontmgr.h

Issue 2451493002: Refcount all the IFX_ stream classes all the time. (Closed)

Patch Set: Clean up cast expression Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxge/android/cfpf_skiafontmgr.h

diff --git a/core/fxge/android/cfpf_skiafontmgr.h b/core/fxge/android/cfpf_skiafontmgr.h

index 7d89c6edb8fda3d9152e6b5c0a295cd684b74723..4d0ea0e0d2df4701096b067ea4d9768a21988398 100644

--- a/core/fxge/android/cfpf_skiafontmgr.h

+++ b/core/fxge/android/cfpf_skiafontmgr.h

@@ -31,7 +31,7 @@ class CFPF_SkiaFontMgr {

uint32_t dwMatch = 0);

bool InitFTLibrary();

- FXFT_Face GetFontFace(IFX_SeekableReadStream* pFileRead,

+ FXFT_Face GetFontFace(const CFX_RetainPtr<IFX_SeekableReadStream>& pFileRead,

int32_t iFaceIndex = 0);

FXFT_Face GetFontFace(const CFX_ByteStringC& bsFile, int32_t iFaceIndex = 0);

FXFT_Face GetFontFace(const uint8_t* pBuffer,

« no previous file with comments | « core/fxge/android/cfpf_skiafilefont.h ('k') | core/fxge/android/cfpf_skiafontmgr.cpp » ('j') | no next file with comments »