core/fxcrt/fx_ext.h - Issue 2451493002: Refcount all the IFX_ stream classes all the time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/fx_ext.h

Issue 2451493002: Refcount all the IFX_ stream classes all the time. (Closed)

Patch Set: Clean up cast expression Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/fx_ext.h

diff --git a/core/fxcrt/fx_ext.h b/core/fxcrt/fx_ext.h

index 7d8529e333dd308d545c03b81c190b2572e3c3eb..737ea849c9cb462a1d9855c5aa0a2cbf7b28b830 100644

--- a/core/fxcrt/fx_ext.h

+++ b/core/fxcrt/fx_ext.h

@@ -15,12 +15,6 @@

#define FX_INVALID_OFFSET static_cast<uint32_t>(-1)

-// TODO(thestig) Using unique_ptr with ReleaseDeleter is still not ideal.

-// Come up or wait for something better. This appears in this file rather

-// than fx_stream.h due to include ordering restrictions.

-using ScopedFileStream =

- std::unique_ptr<IFX_SeekableStream, ReleaseDeleter<IFX_SeekableStream>>;

FX_FLOAT FXSYS_tan(FX_FLOAT a);

FX_FLOAT FXSYS_logb(FX_FLOAT b, FX_FLOAT x);

FX_FLOAT FXSYS_strtof(const FX_CHAR* pcsStr,

« no previous file with comments | « core/fxcrt/fx_basic_buffer.cpp ('k') | core/fxcrt/fx_extension.cpp » ('j') | no next file with comments »