core/fxcodec/codec/ccodec_tiffmodule.h - Issue 2451493002: Refcount all the IFX_ stream classes all the time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcodec/codec/ccodec_tiffmodule.h

Issue 2451493002: Refcount all the IFX_ stream classes all the time. (Closed)

Patch Set: Clean up cast expression Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcodec/codec/ccodec_tiffmodule.h

diff --git a/core/fxcodec/codec/ccodec_tiffmodule.h b/core/fxcodec/codec/ccodec_tiffmodule.h

index 37d40821a6f1a7f004d5acbe7a83bcf76113aaeb..dd2cbd768ccaf1539ddebffa18e488bbfcbfc8ef 100644

--- a/core/fxcodec/codec/ccodec_tiffmodule.h

+++ b/core/fxcodec/codec/ccodec_tiffmodule.h

@@ -7,6 +7,7 @@

#ifndef CORE_FXCODEC_CODEC_CCODEC_TIFFMODULE_H_

#define CORE_FXCODEC_CODEC_CCODEC_TIFFMODULE_H_

+#include "core/fxcrt/cfx_retain_ptr.h"

#include "core/fxcrt/fx_system.h"

class CCodec_TiffContext;

@@ -18,7 +19,8 @@ class CCodec_TiffModule {

public:

~CCodec_TiffModule() {}

- CCodec_TiffContext* CreateDecoder(IFX_SeekableReadStream* file_ptr);

+ CCodec_TiffContext* CreateDecoder(

+ const CFX_RetainPtr<IFX_SeekableReadStream>& file_ptr);

bool LoadFrameInfo(CCodec_TiffContext* ctx,

int32_t frame,