core/fpdfapi/parser/fpdf_parser_utility.cpp - Issue 2451493002: Refcount all the IFX_ stream classes all the time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/fpdf_parser_utility.cpp

Issue 2451493002: Refcount all the IFX_ stream classes all the time. (Closed)

Patch Set: Clean up cast expression Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/fpdf_parser_utility.cpp

diff --git a/core/fpdfapi/parser/fpdf_parser_utility.cpp b/core/fpdfapi/parser/fpdf_parser_utility.cpp

index ef37d8f39e35997850f2fb96059e64074977326c..9583ea70bcb41c35acfe8a3a09f9f84c2661bbfa 100644

--- a/core/fpdfapi/parser/fpdf_parser_utility.cpp

+++ b/core/fpdfapi/parser/fpdf_parser_utility.cpp

@@ -69,7 +69,7 @@ const char PDF_CharType[256] = {

'R', 'R', 'R', 'R', 'R', 'R', 'R', 'R', 'R', 'R', 'R', 'R', 'R', 'R', 'R',

'R', 'R', 'R', 'R', 'R', 'R', 'R', 'W'};

-int32_t GetHeaderOffset(IFX_SeekableReadStream* pFile) {

+int32_t GetHeaderOffset(const CFX_RetainPtr<IFX_SeekableReadStream>& pFile) {

const size_t kBufSize = 4;

uint8_t buf[kBufSize];

for (int32_t offset = 0; offset <= 1024; ++offset) {