Issue 2451473002: Follow up: stop mirroring session when tab is closed. Rename the callback function and clarify the …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2451473002: Follow up: stop mirroring session when tab is closed. Rename the callback function and clarify the … (Closed)

Created:
4 years, 1 month ago by miu

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

Follow up: stop mirroring session when tab is closed. Rename the callback function and clarify the logic to prevent same bug happen again in future. BUG=655240 Review-Url: https://chromiumcodereview.appspot.com/2432373003 Cr-Commit-Position: refs/heads/master@{#426327} (cherry picked from commit 7be1ce80e3dbf1f42a0c6568d5d894b508e47af7) Committed: https://chromium.googlesource.com/chromium/src/+/c4edd4994e815e13a5ce741fcf35111a465175e5

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -9 lines)			Patch
M	content/renderer/media/media_stream_video_capturer_source.h	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	content/renderer/media/media_stream_video_capturer_source.cc	View	2 chunks	+14 lines, -7 lines	0 comments	Download
M	content/renderer/media/media_stream_video_capturer_source_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

miu

4 years, 1 month ago (2016-10-24 22:00:56 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c4edd4994e815e13a5ce741fcf35111a465175e5.