Issue 2451463002: [Merge] This patch fills in the TODOs in StartupTabProvider regarding pinned tabs and user preferen…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2451463002: [Merge] This patch fills in the TODOs in StartupTabProvider regarding pinned tabs and user preferen… (Closed)

Created:
4 years, 1 month ago by anthonyvd

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

[Merge] This patch fills in the TODOs in StartupTabProvider regarding pinned tabs and user preferences-specified default tabs. BUG=656139, 248883, 517248 Review-Url: https://chromiumcodereview.appspot.com/2396133002 Cr-Commit-Position: refs/heads/master@{#426339} (cherry picked from commit f51ecc9beca2aadad233c44ed098406361d128a8) Committed: https://chromium.googlesource.com/chromium/src/+/802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -18 lines)			Patch
M	chrome/browser/ui/startup/startup_browser_creator_impl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/startup/startup_tab_provider.h	View	3 chunks	+11 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/startup/startup_tab_provider.cc	View	4 chunks	+21 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/startup/startup_tab_provider_unittest.cc	View	1 chunk	+27 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

anthonyvd

4 years, 1 month ago (2016-10-24 22:00:57 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4.