Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2451423003:
Add a test case for bug 659109 (Closed)
|
Created:
4 years, 1 month ago by joone Modified:
4 years, 1 month ago Reviewers:
yosin_UTC9 CC:
blink-reviews, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a test case for bug 659109
<div contenteditable="true"><br> </div>
When we run the above example with M54/55, mutiple
spaces can't be added under <div> because two plain
spaces are collapsed into one space while typing.
This is a regression caused by https://codereview.chromium.org/2175163004.
It was fixed in M56: https://codereview.chromium.org/2432083003.
This test case is added to reproduce the problem mentioned in the bug report.
BUG=659109
TEST=editing/inserting/insert-space.html
Committed: https://crrev.com/f9400ff295d15df932a5ffc903e4ab42163b1b4d
Cr-Commit-Position: refs/heads/master@{#428639}
Patch Set 1 #
Total comments: 2
Patch Set 2 : updated the test case #Messages
Total messages: 24 (17 generated)
The CQ bit was checked by joone.hur@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Add a test case for Bug 659109 <div contenteditable="true"><br> </div> When we run the above example with Chromium 54, we can only add a space under <div> because a regular space is added next to <br> then two spaces are collapsed into one plain space. This is a regression caused by https://codereview.chromium.org/2175163004. It was fixed in https://codereview.chromium.org/2432083003. This test case is added to reproduce the problem mentioned in the bug report. BUG=659109 TEST=editing/inserting/insert-space.html ========== to ========== Add a test case for Bug 659109 <div contenteditable="true"><br> </div> When we run the above example with M54/55, we can only add a space under <div> because a space is added next to <br> then two spaces are collapsed into one plain space. This is a regression caused by https://codereview.chromium.org/2175163004. It was fixed in M56: https://codereview.chromium.org/2432083003. This test case is added to reproduce the problem mentioned in the bug report. BUG=659109 TEST=editing/inserting/insert-space.html ==========
Description was changed from ========== Add a test case for Bug 659109 <div contenteditable="true"><br> </div> When we run the above example with M54/55, we can only add a space under <div> because a space is added next to <br> then two spaces are collapsed into one plain space. This is a regression caused by https://codereview.chromium.org/2175163004. It was fixed in M56: https://codereview.chromium.org/2432083003. This test case is added to reproduce the problem mentioned in the bug report. BUG=659109 TEST=editing/inserting/insert-space.html ========== to ========== Add a test case for bug 659109 <div contenteditable="true"><br> </div> When we run the above example with M54/55, we can only add a space under <div> because a space is added next to <br> then two spaces are collapsed into one plain space. This is a regression caused by https://codereview.chromium.org/2175163004. It was fixed in M56: https://codereview.chromium.org/2432083003. This test case is added to reproduce the problem mentioned in the bug report. BUG=659109 TEST=editing/inserting/insert-space.html ==========
Description was changed from ========== Add a test case for bug 659109 <div contenteditable="true"><br> </div> When we run the above example with M54/55, we can only add a space under <div> because a space is added next to <br> then two spaces are collapsed into one plain space. This is a regression caused by https://codereview.chromium.org/2175163004. It was fixed in M56: https://codereview.chromium.org/2432083003. This test case is added to reproduce the problem mentioned in the bug report. BUG=659109 TEST=editing/inserting/insert-space.html ========== to ========== Add a test case for bug 659109 <div contenteditable="true"><br> </div> When we run the above example with M54/55, we can only add a space under <div> because a space is added and then two spaces are collapsed into one space. This is a regression caused by https://codereview.chromium.org/2175163004. It was fixed in M56: https://codereview.chromium.org/2432083003. This test case is added to reproduce the problem mentioned in the bug report. BUG=659109 TEST=editing/inserting/insert-space.html ==========
joone.hur@intel.com changed reviewers: + yosin@chromium.org
Hi yosin@ we need to add this test just in case.
Description was changed from ========== Add a test case for bug 659109 <div contenteditable="true"><br> </div> When we run the above example with M54/55, we can only add a space under <div> because a space is added and then two spaces are collapsed into one space. This is a regression caused by https://codereview.chromium.org/2175163004. It was fixed in M56: https://codereview.chromium.org/2432083003. This test case is added to reproduce the problem mentioned in the bug report. BUG=659109 TEST=editing/inserting/insert-space.html ========== to ========== Add a test case for bug 659109 <div contenteditable="true"><br> </div> When we run the above example with M54/55, mutiple spaces can't be added under <div> because two spaces are collapsed into one space while typing. This is a regression caused by https://codereview.chromium.org/2175163004. It was fixed in M56: https://codereview.chromium.org/2432083003. This test case is added to reproduce the problem mentioned in the bug report. BUG=659109 TEST=editing/inserting/insert-space.html ==========
https://codereview.chromium.org/2451423003/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/editing/inserting/insert-space.html (right): https://codereview.chromium.org/2451423003/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/editing/inserting/insert-space.html:54: var editor = selection.document.getElementById('editor'); We don't need to have id="editor", you can write as <div contenteditable>|<br> </div>
The CQ bit was checked by joone.hur@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks for review! https://codereview.chromium.org/2451423003/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/editing/inserting/insert-space.html (right): https://codereview.chromium.org/2451423003/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/editing/inserting/insert-space.html:54: var editor = selection.document.getElementById('editor'); On 2016/10/28 06:13:50, Yosi_UTC9 wrote: > We don't need to have id="editor", you can write as > <div contenteditable>|<br> </div> Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Add a test case for bug 659109 <div contenteditable="true"><br> </div> When we run the above example with M54/55, mutiple spaces can't be added under <div> because two spaces are collapsed into one space while typing. This is a regression caused by https://codereview.chromium.org/2175163004. It was fixed in M56: https://codereview.chromium.org/2432083003. This test case is added to reproduce the problem mentioned in the bug report. BUG=659109 TEST=editing/inserting/insert-space.html ========== to ========== Add a test case for bug 659109 <div contenteditable="true"><br> </div> When we run the above example with M54/55, mutiple spaces can't be added under <div> because two plain spaces are collapsed into one space while typing. This is a regression caused by https://codereview.chromium.org/2175163004. It was fixed in M56: https://codereview.chromium.org/2432083003. This test case is added to reproduce the problem mentioned in the bug report. BUG=659109 TEST=editing/inserting/insert-space.html ==========
The CQ bit was checked by yosin@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add a test case for bug 659109 <div contenteditable="true"><br> </div> When we run the above example with M54/55, mutiple spaces can't be added under <div> because two plain spaces are collapsed into one space while typing. This is a regression caused by https://codereview.chromium.org/2175163004. It was fixed in M56: https://codereview.chromium.org/2432083003. This test case is added to reproduce the problem mentioned in the bug report. BUG=659109 TEST=editing/inserting/insert-space.html ========== to ========== Add a test case for bug 659109 <div contenteditable="true"><br> </div> When we run the above example with M54/55, mutiple spaces can't be added under <div> because two plain spaces are collapsed into one space while typing. This is a regression caused by https://codereview.chromium.org/2175163004. It was fixed in M56: https://codereview.chromium.org/2432083003. This test case is added to reproduce the problem mentioned in the bug report. BUG=659109 TEST=editing/inserting/insert-space.html ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add a test case for bug 659109 <div contenteditable="true"><br> </div> When we run the above example with M54/55, mutiple spaces can't be added under <div> because two plain spaces are collapsed into one space while typing. This is a regression caused by https://codereview.chromium.org/2175163004. It was fixed in M56: https://codereview.chromium.org/2432083003. This test case is added to reproduce the problem mentioned in the bug report. BUG=659109 TEST=editing/inserting/insert-space.html ========== to ========== Add a test case for bug 659109 <div contenteditable="true"><br> </div> When we run the above example with M54/55, mutiple spaces can't be added under <div> because two plain spaces are collapsed into one space while typing. This is a regression caused by https://codereview.chromium.org/2175163004. It was fixed in M56: https://codereview.chromium.org/2432083003. This test case is added to reproduce the problem mentioned in the bug report. BUG=659109 TEST=editing/inserting/insert-space.html Committed: https://crrev.com/f9400ff295d15df932a5ffc903e4ab42163b1b4d Cr-Commit-Position: refs/heads/master@{#428639} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f9400ff295d15df932a5ffc903e4ab42163b1b4d Cr-Commit-Position: refs/heads/master@{#428639} |
