Make BrowserMessageFilter not derive from IPC::ChannelProxy::MessageFilter. This allows us to hide …

content/browser/dom_storage/dom_storage_message_filter.cc

Index: content/browser/dom_storage/dom_storage_message_filter.cc
===================================================================
--- content/browser/dom_storage/dom_storage_message_filter.cc	(revision 225319)
+++ content/browser/dom_storage/dom_storage_message_filter.cc	(working copy)
@@ -46,8 +46,6 @@
 }
 
 void DOMStorageMessageFilter::OnFilterAdded(IPC::Channel* channel) {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

[michaeln, 2013/09/26 20:30:16]

is this no longer executed on the IO thread or are you just cleaning up the
dcheck for other reasons?

[jam, 2013/09/26 20:33:18]

these methods are all called on the IO thread. i'm just removing this while
going through the callers. the comment that i say in reviews when i see people
add these is that this is testing the behavior of the core class
(BrowserMessageFilter), and we don't need to do that in every child class.

if you feel strongly about it i can add it back

-  BrowserMessageFilter::OnFilterAdded(channel);
   context_->task_runner()->PostShutdownBlockingTask(
       FROM_HERE,
       DOMStorageTaskRunner::PRIMARY_SEQUENCE,
@@ -55,8 +53,6 @@
 }
 
 void DOMStorageMessageFilter::OnFilterRemoved() {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
-  BrowserMessageFilter::OnFilterRemoved();
   context_->task_runner()->PostShutdownBlockingTask(
       FROM_HERE,
       DOMStorageTaskRunner::PRIMARY_SEQUENCE,