Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: content/browser/loader/resource_dispatcher_host_unittest.cc

Issue 24514003: Make BrowserMessageFilter not derive from IPC::ChannelProxy::MessageFilter. This allows us to hide … (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_unittest.cc
===================================================================
--- content/browser/loader/resource_dispatcher_host_unittest.cc (revision 225900)
+++ content/browser/loader/resource_dispatcher_host_unittest.cc (working copy)
@@ -176,7 +176,7 @@
base::Unretained(this))),
dest_(dest),
resource_context_(resource_context) {
- OnChannelConnected(base::GetCurrentProcId());
+ set_peer_pid_for_testing(base::GetCurrentProcId());
}
// ResourceMessageFilter override
@@ -1804,9 +1804,6 @@
// Make sure we don't hold onto the ResourceMessageFilter after it is deleted.
GlobalRequestID first_global_request_id(first_child_id, request_id);
- const ResourceRequestInfoImpl* info = ResourceRequestInfoImpl::ForRequest(
- host_.GetURLRequest(first_global_request_id));
- EXPECT_FALSE(info->filter());
// This second filter is used to emulate a second process.
scoped_refptr<ForwardingFilter> second_filter = new ForwardingFilter(
« no previous file with comments | « content/browser/indexed_db/indexed_db_dispatcher_host.cc ('k') | content/browser/loader/resource_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698