Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: ipc/ipc_channel_proxy.cc

Issue 24514003: Make BrowserMessageFilter not derive from IPC::ChannelProxy::MessageFilter. This allows us to hide … (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ipc/ipc_channel_proxy.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/compiler_specific.h" 6 #include "base/compiler_specific.h"
7 #include "base/debug/trace_event.h" 7 #include "base/debug/trace_event.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 18 matching lines...) Expand all
29 void ChannelProxy::MessageFilter::OnChannelConnected(int32 peer_pid) {} 29 void ChannelProxy::MessageFilter::OnChannelConnected(int32 peer_pid) {}
30 30
31 void ChannelProxy::MessageFilter::OnChannelError() {} 31 void ChannelProxy::MessageFilter::OnChannelError() {}
32 32
33 void ChannelProxy::MessageFilter::OnChannelClosing() {} 33 void ChannelProxy::MessageFilter::OnChannelClosing() {}
34 34
35 bool ChannelProxy::MessageFilter::OnMessageReceived(const Message& message) { 35 bool ChannelProxy::MessageFilter::OnMessageReceived(const Message& message) {
36 return false; 36 return false;
37 } 37 }
38 38
39 void ChannelProxy::MessageFilter::OnDestruct() const {
40 delete this;
41 }
42
43 ChannelProxy::MessageFilter::~MessageFilter() {} 39 ChannelProxy::MessageFilter::~MessageFilter() {}
44 40
45 //------------------------------------------------------------------------------ 41 //------------------------------------------------------------------------------
46 42
47 ChannelProxy::Context::Context(Listener* listener, 43 ChannelProxy::Context::Context(Listener* listener,
48 base::SingleThreadTaskRunner* ipc_task_runner) 44 base::SingleThreadTaskRunner* ipc_task_runner)
49 : listener_task_runner_(base::ThreadTaskRunnerHandle::Get()), 45 : listener_task_runner_(base::ThreadTaskRunnerHandle::Get()),
50 listener_(listener), 46 listener_(listener),
51 ipc_task_runner_(ipc_task_runner), 47 ipc_task_runner_(ipc_task_runner),
52 channel_connected_called_(false), 48 channel_connected_called_(false),
(...skipping 370 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 Channel* channel = context_.get()->channel_.get(); 419 Channel* channel = context_.get()->channel_.get();
424 // Channel must have been created first. 420 // Channel must have been created first.
425 DCHECK(channel) << context_.get()->channel_id_; 421 DCHECK(channel) << context_.get()->channel_id_;
426 return channel->GetPeerEuid(peer_euid); 422 return channel->GetPeerEuid(peer_euid);
427 } 423 }
428 #endif 424 #endif
429 425
430 //----------------------------------------------------------------------------- 426 //-----------------------------------------------------------------------------
431 427
432 } // namespace IPC 428 } // namespace IPC
OLDNEW
« no previous file with comments | « ipc/ipc_channel_proxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698