Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp

Issue 2451373003: service worker: Implement NavigationPreloadManager.setHeaderValue (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp b/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp
index 9d2a79c8be0dbd4f836b0e09599dc2d4ceb7e34f..1dd01989ef5985ac1e5b4bcc11f9e35fcee727be 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp
@@ -4,10 +4,12 @@
#include "modules/serviceworkers/NavigationPreloadManager.h"
+#include "bindings/core/v8/CallbackPromiseAdapter.h"
#include "core/dom/DOMException.h"
#include "modules/serviceworkers/NavigationPreloadCallbacks.h"
#include "modules/serviceworkers/ServiceWorkerContainerClient.h"
#include "modules/serviceworkers/ServiceWorkerRegistration.h"
+#include "platform/network/HTTPParsers.h"
namespace blink {
@@ -19,10 +21,29 @@ ScriptPromise NavigationPreloadManager::disable(ScriptState* scriptState) {
return setEnabled(false, scriptState);
}
-ScriptPromise NavigationPreloadManager::setHeaderValue(ScriptState*,
+ScriptPromise NavigationPreloadManager::setHeaderValue(ScriptState* scriptState,
const String& value) {
- NOTIMPLEMENTED();
- return ScriptPromise();
+ ServiceWorkerContainerClient* client =
+ ServiceWorkerContainerClient::from(m_registration->getExecutionContext());
+ if (!client || !client->provider()) {
+ return ScriptPromise::rejectWithDOMException(
+ scriptState, DOMException::create(InvalidStateError, "No provider."));
+ }
+
+ if (!isValidHTTPHeaderValue(value)) {
+ return ScriptPromise::reject(
+ scriptState, V8ThrowException::createTypeError(
+ scriptState->isolate(),
+ "The string provided to setHeaderValue ('" + value +
+ "') is not a valid HTTP header field value."));
+ }
+
+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
+ ScriptPromise promise = resolver->promise();
+ m_registration->webRegistration()->setNavigationPreloadHeader(
+ value, client->provider(),
+ wrapUnique(new SetNavigationPreloadHeaderCallbacks(resolver)));
+ return promise;
}
ScriptPromise NavigationPreloadManager::getState(ScriptState* scriptState) {

Powered by Google App Engine
This is Rietveld 408576698