service worker: Implement NavigationPreloadManager.setHeaderValue

content/common/service_worker/service_worker_messages.h

Index: content/common/service_worker/service_worker_messages.h
diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h
index cf1887932bdada354677ebd92aaa9728c6663e89..7cd3d188eba19dac6be0f30db941ce0be29762f5 100644
--- a/content/common/service_worker/service_worker_messages.h
+++ b/content/common/service_worker/service_worker_messages.h
@@ -57,6 +57,11 @@ IPC_STRUCT_TRAITS_BEGIN(content::ExtendableMessageEventSource)
   IPC_STRUCT_TRAITS_MEMBER(service_worker_info)
 IPC_STRUCT_TRAITS_END()
 
+IPC_STRUCT_TRAITS_BEGIN(content::NavigationPreloadState)
+  IPC_STRUCT_TRAITS_MEMBER(enabled)
+  IPC_STRUCT_TRAITS_MEMBER(header)
+IPC_STRUCT_TRAITS_END()
+
 IPC_STRUCT_TRAITS_BEGIN(content::ServiceWorkerFetchRequest)
   IPC_STRUCT_TRAITS_MEMBER(mode)
   IPC_STRUCT_TRAITS_MEMBER(is_main_resource_load)
@@ -202,6 +207,14 @@ IPC_MESSAGE_CONTROL4(ServiceWorkerHostMsg_GetNavigationPreloadState,
                      int /* provider_id */,
                      int64_t /* registration_id */)
 
+// Asks the browser to set navigation preload header value for a registration.
+IPC_MESSAGE_CONTROL5(ServiceWorkerHostMsg_SetNavigationPreloadHeader,
+                     int /* thread_id */,
+                     int /* request_id */,
+                     int /* provider_id */,
+                     int64_t /* registration_id */,
+                     std::string /* header_value */)

[Tom Sepez, 2016/10/31 20:09:49]

Are there any constraints on the values that can be supplied that need to be
validated browser-side? 

For example, what happens if the value contains unexpected punctuation,
newlines, etc. -- can we get in a situation where a compromised renderer might
be able to inject unrelated headers?

[falken, 2016/11/01 00:35:28]

Good question. Yes, the current patchset calls net::HttpUtil::IsValidHeaderValue
in ServiceWorkerDispatcherHost to reject strings that contain CR or LF or \0,
which is important since HTTP header fields are delimited by CRLF. As noted in
the comment, this is more lenient than the Blink-side check of
blink::isValidHTTPHeaderValue, which further restricts the string to
latin1-only. Ideally the checks would match perfectly but rolling our own
isValidHTTPHeaderValue just for this seems like overkill since there's already
one in net::HttpUtil, and filtering out CRLF and \0 seems enough to stop
injection of bad headers.

Actually I think renderers can already send arbitrary headers via
content::ResourceRequest, and these are also validated by
net::HttpUtil::IsValidHeaderValue via ResourceDispatcherHostImpl::BeginRequest
calling HttpRequestHeaders::AddHeadersFromString.

+
 // Sends ExtendableMessageEvent to a service worker (renderer->browser).
 IPC_MESSAGE_CONTROL5(
     ServiceWorkerHostMsg_PostMessageToWorker,
@@ -501,12 +514,20 @@ IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_EnableNavigationPreloadError,
 IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_DidGetNavigationPreloadState,
                      int /* thread_id */,
                      int /* request_id */,
-                     bool /* enabled */)
+                     content::NavigationPreloadState /* state */)
 IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_GetNavigationPreloadStateError,
                      int /* thread_id */,
                      int /* request_id */,
                      blink::WebServiceWorkerError::ErrorType /* code */,
                      std::string /* message */)
+IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_DidSetNavigationPreloadHeader,
+                     int /* thread_id */,
+                     int /* request_id */)
+IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_SetNavigationPreloadHeaderError,
+                     int /* thread_id */,
+                     int /* request_id */,
+                     blink::WebServiceWorkerError::ErrorType /* code */,
+                     std::string /* message */)
 
 // Sends MessageEvent to a client document (browser->renderer).
 IPC_MESSAGE_CONTROL1(ServiceWorkerMsg_MessageToDocument,