[DevTools] Move main target/connection to TargetManager.

[DevTools] Move main target/connection to TargetManager.

This fixes a bunch of issues:
- removes indirection for interceptMainConnection;
- properly handles websocket disconnected screen;
- correctly names Node target.

BUG=648775
Committed: https://crrev.com/484e19f6aa51fc3b24be33cd7ae26d5030b56367
Cr-Commit-Position: refs/heads/master@{#428309}

[dgozman, 2016-10-26 22:33:52]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2016-10-26 22:33:52]

Could you please take a look?

[pfeldman, 2016-10-27 20:50:28]

lgtm

https://codereview.chromium.org/2451363002/diff/1/chrome/browser/devtools/rem...
File chrome/browser/devtools/remote_debugging_server.cc (right):

https://codereview.chromium.org/2451363002/diff/1/chrome/browser/devtools/rem...
chrome/browser/devtools/remote_debugging_server.cc:108:
PathService::Get(chrome::DIR_INSPECTOR_DEBUG, &debug_frontend_dir);
it is already fixed.

[dgozman, 2016-10-27 23:05:11]

Description was changed from

==========
[DevTools] Move main target/connection to TargetManager.

This fixes a bunch of issues:
- removes indirection for interceptMainConnection;
- properly handles websocket disconnected screen;
- correctly names Node target.

Drive-by: fix hosted mode in debug build being actually minified.

BUG=648775
==========

to

==========
[DevTools] Move main target/connection to TargetManager.

This fixes a bunch of issues:
- removes indirection for interceptMainConnection;
- properly handles websocket disconnected screen;
- correctly names Node target.

BUG=648775
==========

[dgozman, 2016-10-28 00:22:31]

https://codereview.chromium.org/2451363002/diff/1/chrome/browser/devtools/rem...
File chrome/browser/devtools/remote_debugging_server.cc (right):

https://codereview.chromium.org/2451363002/diff/1/chrome/browser/devtools/rem...
chrome/browser/devtools/remote_debugging_server.cc:108:
PathService::Get(chrome::DIR_INSPECTOR_DEBUG, &debug_frontend_dir);
On 2016/10/27 20:50:27, pfeldman wrote:
> it is already fixed.

Reverted.

[dgozman, 2016-10-28 00:26:51]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-10-28 00:26:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2451363002/#ps20001
(title: "rebased")

[commit-bot: I haz the power, 2016-10-28 00:27:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 02:44:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 02:44:57]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2016-10-28 06:10:41]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-10-28 06:10:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 07:37:56]

Description was changed from

==========
[DevTools] Move main target/connection to TargetManager.

This fixes a bunch of issues:
- removes indirection for interceptMainConnection;
- properly handles websocket disconnected screen;
- correctly names Node target.

BUG=648775
==========

to

==========
[DevTools] Move main target/connection to TargetManager.

This fixes a bunch of issues:
- removes indirection for interceptMainConnection;
- properly handles websocket disconnected screen;
- correctly names Node target.

BUG=648775
==========

[commit-bot: I haz the power, 2016-10-28 07:37:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-28 07:40:49]

Description was changed from

==========
[DevTools] Move main target/connection to TargetManager.

This fixes a bunch of issues:
- removes indirection for interceptMainConnection;
- properly handles websocket disconnected screen;
- correctly names Node target.

BUG=648775
==========

to

==========
[DevTools] Move main target/connection to TargetManager.

This fixes a bunch of issues:
- removes indirection for interceptMainConnection;
- properly handles websocket disconnected screen;
- correctly names Node target.

BUG=648775

Committed: https://crrev.com/484e19f6aa51fc3b24be33cd7ae26d5030b56367
Cr-Commit-Position: refs/heads/master@{#428309}
==========

[commit-bot: I haz the power, 2016-10-28 07:40:49]

Patchset 2 (id:??) landed as
https://crrev.com/484e19f6aa51fc3b24be33cd7ae26d5030b56367
Cr-Commit-Position: refs/heads/master@{#428309}