Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2298)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java

Issue 2451303002: [Payments] Don't add expired cards in Payment Request. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
index c299f081a92d33bb59c43d224602aef2a68fa412..4bac0d83f6e0334edef7bde79e3b65e01ec6a0a8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
@@ -195,6 +195,27 @@ public class EditorFieldModel {
return result;
}
+ /**
+ * Constructs a dropdown field model.
please use gerrit instead 2016/10/27 00:05:22 ... with a validator.
sebsg 2016/10/27 14:38:00 Done.
+ *
+ * @param label The human-readable label for user to understand the type of data
+ * that should be entered into this field.
+ * @param dropdownKeyValues The keyed values to display in the dropdown.
+ * @param validator Optional validator for the values in this field.
please use gerrit instead 2016/10/27 00:05:22 Let's make it non-optional. If the user of this AP
sebsg 2016/10/27 14:38:00 Done.
+ * @param requiredErrorMessage The optional error message that indicates to the user that they
+ * cannot leave this field empty.
+ */
please use gerrit instead 2016/10/27 00:05:22 Comment indent.
sebsg 2016/10/27 14:38:00 Done.
+ public static EditorFieldModel createDropdown(
+ @Nullable CharSequence label, List<DropdownKeyValue> dropdownKeyValues,
+ @Nullable EditorFieldValidator validator,
+ @Nullable CharSequence invalidErrorMessage) {
+ assert dropdownKeyValues != null;
+ EditorFieldModel result = createDropdown(label, dropdownKeyValues);
+ result.mValidator = validator;
+ result.mInvalidErrorMessage = invalidErrorMessage;
+ return result;
+ }
+
/** Constructs a text input field model without any special text formatting hints. */
public static EditorFieldModel createTextInput() {
return new EditorFieldModel(INPUT_TYPE_HINT_NONE);

Powered by Google App Engine
This is Rietveld 408576698