Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2451283004: Merged: [turbofan] Fix typing rule for Math.sign. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.4
Project:
v8
Visibility:
Public.

Description

Merged: [turbofan] Fix typing rule for Math.sign. Revision: 25504a220f75f88b565cf36df73c00e5f2702c65 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=ishell@chromium.org BUG=chromium:658114 Committed: https://chromium.googlesource.com/v8/v8/+/cac06c728dbc504464265ba15e7752699e21042d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/compiler/typer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/type-cache.h View 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/compiler/regress-math-sign-nan-type.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
4 years, 1 month ago (2016-10-27 12:12:37 UTC) #1
Benedikt Meurer
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years, 1 month ago (2016-10-27 12:12:38 UTC) #2
Igor Sheludko
lgtm
4 years, 1 month ago (2016-10-27 12:14:29 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as cac06c728dbc504464265ba15e7752699e21042d.
4 years, 1 month ago (2016-10-27 12:22:41 UTC) #5
Michael Hablich
4 years, 1 month ago (2016-10-27 14:08:37 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2455503006/ by hablich@chromium.org.

The reason for reverting is: Breaks tests:
https://chromegw.corp.google.com/i/client.v8.branches/builders/V8%20Linux%20-....

Powered by Google App Engine
This is Rietveld 408576698