Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2451273006: Shared image generator (Closed)

Created:
4 years, 1 month ago by f(malita)
Modified:
4 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Shared image generator Introduce a new ref counted class (SharedGenerator), to facilitate SkImageGenerator sharing among multiple cacherators. Plumbing only for now, no actual sharing. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2451273006 Committed: https://skia.googlesource.com/skia/+/f0c38f5fe625bc67f647d58ac803bf4ba427e99e

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -37 lines) Patch
M src/core/SkImageCacherator.h View 4 chunks +15 lines, -25 lines 0 comments Download
M src/core/SkImageCacherator.cpp View 1 10 chunks +57 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
f(malita)
4 years, 1 month ago (2016-10-27 20:21:35 UTC) #4
reed1
lgtm
4 years, 1 month ago (2016-10-27 20:44:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451273006/20001
4 years, 1 month ago (2016-10-27 21:09:16 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 21:22:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f0c38f5fe625bc67f647d58ac803bf4ba427e99e

Powered by Google App Engine
This is Rietveld 408576698