Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2451273005: [android] Pass SIGTERM from logdog_wrapper to its wrapped test command. (Closed)

Created:
4 years, 1 month ago by jbudorick
Modified:
4 years, 1 month ago
Reviewers:
bpastene
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android] Pass SIGTERM from logdog_wrapper to its wrapped test command. BUG=654538 Committed: https://crrev.com/7a34aeb49e6381c2d79356a688af6645ecba4e93 Cr-Commit-Position: refs/heads/master@{#428109}

Patch Set 1 #

Total comments: 2

Patch Set 2 : bpastene comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M build/android/test_wrapper/logdog_wrapper.py View 1 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
jbudorick
4 years, 1 month ago (2016-10-27 01:55:05 UTC) #2
bpastene
nice, lgtm https://codereview.chromium.org/2451273005/diff/1/build/android/test_wrapper/logdog_wrapper.py File build/android/test_wrapper/logdog_wrapper.py (right): https://codereview.chromium.org/2451273005/diff/1/build/android/test_wrapper/logdog_wrapper.py#newcode45 build/android/test_wrapper/logdog_wrapper.py:45: proc.send_signal(signum) Not sure where this logs to, ...
4 years, 1 month ago (2016-10-27 17:46:14 UTC) #3
jbudorick
https://codereview.chromium.org/2451273005/diff/1/build/android/test_wrapper/logdog_wrapper.py File build/android/test_wrapper/logdog_wrapper.py (right): https://codereview.chromium.org/2451273005/diff/1/build/android/test_wrapper/logdog_wrapper.py#newcode45 build/android/test_wrapper/logdog_wrapper.py:45: proc.send_signal(signum) On 2016/10/27 17:46:14, bpastene wrote: > Not sure ...
4 years, 1 month ago (2016-10-27 18:09:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451273005/20001
4 years, 1 month ago (2016-10-27 18:09:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 19:28:35 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 19:32:48 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a34aeb49e6381c2d79356a688af6645ecba4e93
Cr-Commit-Position: refs/heads/master@{#428109}

Powered by Google App Engine
This is Rietveld 408576698