Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2451243002: Refactoring in rebaseline.py: Combine BaseInternalRebaselineCommand and AbstractRebaseliningCommand. (Closed)

Created:
4 years, 1 month ago by qyearsley
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring in rebaseline.py: Combine BaseInternalRebaselineCommand and AbstractRebaseliningCommand. Reason: this simplifies the class hierarchy. BUG=616967 Committed: https://crrev.com/3078bc85c2b7d7f8feddd8d19b7a11e2fbed9d90 Cr-Commit-Position: refs/heads/master@{#428159}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -25 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 1 3 chunks +33 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
qyearsley
4 years, 1 month ago (2016-10-27 17:03:50 UTC) #4
Dirk Pranke
lgtm
4 years, 1 month ago (2016-10-27 21:00:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451243002/20001
4 years, 1 month ago (2016-10-27 21:09:35 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 22:14:34 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 22:16:40 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3078bc85c2b7d7f8feddd8d19b7a11e2fbed9d90
Cr-Commit-Position: refs/heads/master@{#428159}

Powered by Google App Engine
This is Rietveld 408576698