Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 2451233002: Make request fail with ERR_CONTENT_DECODING_INIT_FAILED if sdch is not supported (Closed)
Patch Set: Address Matt's comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/filter/sdch_policy_delegate.cc ('k') | net/url_request/url_request_http_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 9e64ee0527dfdde29636832f02e60a7e244225c9..a7c31c3f794443f5e011107d06a59f9c8ec2517f 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -1117,14 +1117,16 @@ std::unique_ptr<SourceStream> URLRequestHttpJob::SetUpSourceStream() {
break;
case SourceStream::TYPE_SDCH:
case SourceStream::TYPE_SDCH_POSSIBLE: {
- GURL url = request()->url();
- std::unique_ptr<SdchPolicyDelegate> delegate(new SdchPolicyDelegate(
- type == SourceStream::TYPE_SDCH_POSSIBLE, this, mime_type, url,
- is_cached_content_, request()->context()->sdch_manager(),
- std::move(dictionaries_advertised_), GetResponseCode(),
- request()->net_log()));
- downstream.reset(new SdchSourceStream(std::move(upstream),
- std::move(delegate), type));
+ if (request()->context()->sdch_manager()) {
+ GURL url = request()->url();
+ std::unique_ptr<SdchPolicyDelegate> delegate(new SdchPolicyDelegate(
+ type == SourceStream::TYPE_SDCH_POSSIBLE, this, mime_type, url,
+ is_cached_content_, request()->context()->sdch_manager(),
+ std::move(dictionaries_advertised_), GetResponseCode(),
+ request()->net_log()));
+ downstream.reset(new SdchSourceStream(std::move(upstream),
+ std::move(delegate), type));
+ }
break;
}
case SourceStream::TYPE_GZIP:
« no previous file with comments | « net/filter/sdch_policy_delegate.cc ('k') | net/url_request/url_request_http_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698