build_scan: Raise ValueError on URL fetch error

build_scan: Raise ValueError on URL fetch error

When url fetches error, they raise a URLError, which apparently has a SSLContext
object contained in them, which can't be pickled. This seems to break gatekeeper,
because it uses multiprocessing, and python doesn't know how to pickle
SSLContext objects.

BUG=653262
Committed: https://chromium.googlesource.com/chromium/tools/build/+/6e390490ae0e00dcb1f058f30a61dde88cb55626

[martiniss, 2016-10-27 22:54:55]

martiniss@chromium.org changed reviewers:
+ stip@chromium.org

[martiniss, 2016-10-27 22:54:56]

PTAL

[ghost stip (do not use), 2016-10-27 23:41:19]

lgtm w/ comment

https://codereview.chromium.org/2451213004/diff/1/scripts/slave/build_scan.py
File scripts/slave/build_scan.py (right):

https://codereview.chromium.org/2451213004/diff/1/scripts/slave/build_scan.py...
scripts/slave/build_scan.py:249: msg = "URL Fetch timed out: %s" % f
probably want to make this something like "Error encountered during URL Fetch:",
it might not be a timeout?

[martiniss, 2016-10-27 23:44:04]

Done

https://codereview.chromium.org/2451213004/diff/1/scripts/slave/build_scan.py
File scripts/slave/build_scan.py (right):

https://codereview.chromium.org/2451213004/diff/1/scripts/slave/build_scan.py...
scripts/slave/build_scan.py:249: msg = "URL Fetch timed out: %s" % f
On 2016/10/27 at 23:41:18, stip wrote:
> probably want to make this something like "Error encountered during URL
Fetch:", it might not be a timeout?

Done.

[martiniss, 2016-10-27 23:44:08]

The CQ bit was checked by martiniss@chromium.org

[martiniss, 2016-10-27 23:44:08]

The patchset sent to the CQ was uploaded after l-g-t-m from stip@chromium.org
Link to the patchset: https://codereview.chromium.org/2451213004/#ps20001
(title: "Comment")

[commit-bot: I haz the power, 2016-10-27 23:44:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:54:07]

Description was changed from

==========
build_scan: Raise ValueError on URL fetch error

When url fetches error, they raise a URLError, which apparently has a SSLContext
object contained in them, which can't be pickled. This seems to break
gatekeeper,
because it uses multiprocessing, and python doesn't know how to pickle
SSLContext objects.

BUG=653262
==========

to

==========
build_scan: Raise ValueError on URL fetch error

When url fetches error, they raise a URLError, which apparently has a SSLContext
object contained in them, which can't be pickled. This seems to break
gatekeeper,
because it uses multiprocessing, and python doesn't know how to pickle
SSLContext objects.

BUG=653262

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/6e390490ae0e00dcb1f0...
==========

[commit-bot: I haz the power, 2016-10-27 23:54:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/6e390490ae0e00dcb1f0...