Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2451203002: Revert of Use ChannelMojo between the remoting daemon and network processes. (Closed)

Created:
4 years, 1 month ago by dmazzoni
Modified:
4 years, 1 month ago
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use ChannelMojo between the remoting daemon and network processes. (patchset #4 id:180001 of https://codereview.chromium.org/2424353002/ ) Reason for revert: http://crbug.com/659219 Causes WorkerProcessLauncherTest.Crash to fail on multiple Win bots Original issue's description: > Use ChannelMojo between the remoting daemon and network processes. > > This refactors LaunchProcessWithToken to take an explicit list of > handles for the child to inherit (copied from the equivalent process > launch code in //base). > > This also changes WorkerProcessLauncherTest to use ChannelMojo. > > BUG=604282 > > Committed: https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4 > Cr-Commit-Position: refs/heads/master@{#427238} TBR=rockot@chromium.org,joedow@chromium.org,sergeyu@chromium.org,sammc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=604282 Committed: https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756 Cr-Commit-Position: refs/heads/master@{#427765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -178 lines) Patch
M remoting/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/base/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/base/auto_thread_task_runner.h View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/base/run_all_unittests.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/host/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/host/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/daemon_process_win.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M remoting/host/host_main.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 4 chunks +20 lines, -17 lines 0 comments Download
M remoting/host/switches.h View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/host/switches.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/win/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/win/launch_process_with_token.h View 2 chunks +18 lines, -15 lines 0 comments Download
M remoting/host/win/launch_process_with_token.cc View 3 chunks +27 lines, -51 lines 0 comments Download
M remoting/host/win/unprivileged_process_delegate.cc View 3 chunks +43 lines, -45 lines 0 comments Download
M remoting/host/win/worker_process_launcher_unittest.cc View 6 chunks +14 lines, -8 lines 0 comments Download
M remoting/host/win/wts_session_process_delegate.cc View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dmazzoni
Created Revert of Use ChannelMojo between the remoting daemon and network processes.
4 years, 1 month ago (2016-10-26 15:25:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451203002/1
4 years, 1 month ago (2016-10-26 15:25:52 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/319519)
4 years, 1 month ago (2016-10-26 17:38:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451203002/1
4 years, 1 month ago (2016-10-26 17:48:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 18:53:26 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 19:22:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756
Cr-Commit-Position: refs/heads/master@{#427765}

Powered by Google App Engine
This is Rietveld 408576698