Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2527)

Unified Diff: cc/trees/property_tree_builder.cc

Issue 2451183002: Add sticky nodes affected by inner and outer viewport bounds deltas. (Closed)
Patch Set: Add to nodes affected by inner/outer viewport only, improve test coverage. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_common_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/property_tree_builder.cc
diff --git a/cc/trees/property_tree_builder.cc b/cc/trees/property_tree_builder.cc
index 17ed191d074f8376327c66cc192f0c4267ff7e75..cf63139d8180e9d9e2879624b8b009bd715f38e2 100644
--- a/cc/trees/property_tree_builder.cc
+++ b/cc/trees/property_tree_builder.cc
@@ -705,9 +705,15 @@ bool AddTransformNodeIfNeeded(
ScrollNode* scroll_ancestor =
data_for_children->property_trees->scroll_tree.Node(
sticky_data->scroll_ancestor);
- if (scroll_ancestor->is_inner_viewport_scroll_layer) {
- data_for_children->property_trees->transform_tree
- .AddNodeAffectedByInnerViewportBoundsDelta(node->id);
+ if (sticky_data->constraints.is_anchored_right ||
+ sticky_data->constraints.is_anchored_bottom) {
+ if (scroll_ancestor->is_inner_viewport_scroll_layer) {
+ data_for_children->property_trees->transform_tree
+ .AddNodeAffectedByInnerViewportBoundsDelta(node->id);
ajuma 2016/10/28 17:10:41 As discussed, please rename TransformNode::affecte
flackr 2016/10/28 17:24:51 Done.
+ } else if (scroll_ancestor->is_outer_viewport_scroll_layer) {
+ data_for_children->property_trees->transform_tree
+ .AddNodeAffectedByOuterViewportBoundsDelta(node->id);
+ }
}
sticky_data->main_thread_offset =
layer->position().OffsetFromOrigin() -
« no previous file with comments | « cc/trees/layer_tree_host_common_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698