Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2451173002: [tools] Support more map information in --trace-ic and ic-explorer.html (Closed)

Created:
4 years, 1 month ago by Camillo Bruni
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Support more map information in --trace-ic and ic-explorer.html BUG= Committed: https://crrev.com/433cd531dfd8b7d01c056f7d72ab92797d80b7a1 Cr-Commit-Position: refs/heads/master@{#40611}

Patch Set 1 #

Patch Set 2 : formatting #

Patch Set 3 : making compilers happy #

Patch Set 4 : parenthesis to the rescue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -53 lines) Patch
M src/ic/ic.cc View 1 2 3 2 chunks +46 lines, -38 lines 0 comments Download
M tools/ic-explorer.html View 6 chunks +42 lines, -15 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Camillo Bruni
PTAL
4 years, 1 month ago (2016-10-26 14:24:32 UTC) #2
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-10-26 14:47:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451173002/20001
4 years, 1 month ago (2016-10-26 15:11:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/6921)
4 years, 1 month ago (2016-10-26 15:15:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451173002/40001
4 years, 1 month ago (2016-10-27 09:03:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/11455) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-10-27 09:05:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451173002/60001
4 years, 1 month ago (2016-10-27 09:29:19 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-27 09:55:36 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:15:03 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/433cd531dfd8b7d01c056f7d72ab92797d80b7a1
Cr-Commit-Position: refs/heads/master@{#40611}

Powered by Google App Engine
This is Rietveld 408576698