[promises] Move PromiseReject to c++

[promises] Move PromiseReject to c++

This patch refactors most of FulfillPromise runtime call out to a separate
function so that we can to it from PromiseReject runtime call.

This patch adds a PromiseStatus enum.

BUG=v8:5343
Committed: https://crrev.com/f80f450993f926e6b4cd2d4b0bbf9c931bb199a1
Cr-Commit-Position: refs/heads/master@{#40615}

[gsathya, 2016-10-26 13:52:24]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 13:52:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 13:53:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 13:53:39]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/15249)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/15274)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/15210)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/11523)

[gsathya, 2016-10-26 13:55:13]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 13:55:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2016-10-26 13:56:29]

Description was changed from

==========
[promises] Move PromiseReject to c++

BUG=v8:5343
==========

to

==========
[promises] Move PromiseReject to c++

This patch refactors most of FulfillPromise runtime call out to a separate 
function so that we can to it from PromiseReject runtime call.

This patch also exports PromiseSet and kPromiseRejected.

BUG=v8:5343
==========

[gsathya, 2016-10-26 13:58:09]

gsathya@chromium.org changed reviewers:
+ adamk@chromium.org

[gsathya, 2016-10-26 13:58:09]

We export kRejectedPromise and PromiseSet for async await which is weird since
they're internal to promises. I could potentially keep PromiseReject around for
async await. Thoughts?

[commit-bot: I haz the power, 2016-10-26 14:15:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 14:15:46]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[gsathya, 2016-10-26 14:33:32]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 14:33:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-10-26 14:39:50]

I'd prefer to keep RejectPromise as a two-line function in promise.js and export
that.

https://codereview.chromium.org/2451163003/diff/40001/src/runtime/runtime-int...
File src/runtime/runtime-internal.cc (right):

https://codereview.chromium.org/2451163003/diff/40001/src/runtime/runtime-int...
src/runtime/runtime-internal.cc:625: const int kRejected = 2;
This needs a comment that it must be kept in sync with the same thing in
promise.js (and add a comment in promise.js referring back here).

[commit-bot: I haz the power, 2016-10-26 14:50:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 14:50:08]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[gsathya, 2016-10-26 14:59:16]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 14:59:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 15:15:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 15:15:13]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/11536)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[gsathya, 2016-10-26 15:41:58]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 15:42:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2016-10-26 16:00:50]

On 2016/10/26 14:39:50, adamk wrote:
> I'd prefer to keep RejectPromise as a two-line function in promise.js and
export
> that.

Done. 

>
https://codereview.chromium.org/2451163003/diff/40001/src/runtime/runtime-int...
> File src/runtime/runtime-internal.cc (right):
> 
>
https://codereview.chromium.org/2451163003/diff/40001/src/runtime/runtime-int...
> src/runtime/runtime-internal.cc:625: const int kRejected = 2;
> This needs a comment that it must be kept in sync with the same thing in
> promise.js (and add a comment in promise.js referring back here).

Done.

[commit-bot: I haz the power, 2016-10-26 16:08:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 16:08:19]

Dry run: This issue passed the CQ dry run.

[gsathya, 2016-10-26 16:46:52]

Description was changed from

==========
[promises] Move PromiseReject to c++

This patch refactors most of FulfillPromise runtime call out to a separate 
function so that we can to it from PromiseReject runtime call.

This patch also exports PromiseSet and kPromiseRejected.

BUG=v8:5343
==========

to

==========
[promises] Move PromiseReject to c++

This patch refactors most of FulfillPromise runtime call out to a separate 
function so that we can to it from PromiseReject runtime call.

This patch adds a PromiseStatus enum.

BUG=v8:5343
==========

[gsathya, 2016-10-26 16:51:00]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 16:51:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2016-10-26 16:51:24]

On 2016/10/26 16:00:50, gsathya wrote:
> On 2016/10/26 14:39:50, adamk wrote:
> > I'd prefer to keep RejectPromise as a two-line function in promise.js and
> export
> > that.
> 
> Done. 
> 
> >
>
https://codereview.chromium.org/2451163003/diff/40001/src/runtime/runtime-int...
> > File src/runtime/runtime-internal.cc (right):
> > 
> >
>
https://codereview.chromium.org/2451163003/diff/40001/src/runtime/runtime-int...
> > src/runtime/runtime-internal.cc:625: const int kRejected = 2;
> > This needs a comment that it must be kept in sync with the same thing in
> > promise.js (and add a comment in promise.js referring back here).
> 
> Done.

Added enum.

[gsathya, 2016-10-26 16:52:50]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 16:52:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 17:22:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 17:22:23]

Dry run: This issue passed the CQ dry run.

[gsathya, 2016-10-27 07:45:26]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 07:45:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-10-27 08:02:35]

https://codereview.chromium.org/2451163003/diff/140001/src/js/promise.js
File src/js/promise.js (right):

https://codereview.chromium.org/2451163003/diff/140001/src/js/promise.js#newc...
src/js/promise.js:319: return;
No need for this empty return

https://codereview.chromium.org/2451163003/diff/140001/src/runtime/runtime-in...
File src/runtime/runtime-internal.cc (right):

https://codereview.chromium.org/2451163003/diff/140001/src/runtime/runtime-in...
src/runtime/runtime-internal.cc:302:
isolate->ReportPromiseReject(Handle<JSObject>::cast(promise), value,
Why is this safe? Or rather, why did the promise argument change to a
JSReceiver?

[commit-bot: I haz the power, 2016-10-27 08:24:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 08:25:00]

Dry run: This issue passed the CQ dry run.

[gsathya, 2016-10-27 11:20:05]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 11:20:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2016-10-27 11:27:48]

https://codereview.chromium.org/2451163003/diff/140001/src/js/promise.js
File src/js/promise.js (right):

https://codereview.chromium.org/2451163003/diff/140001/src/js/promise.js#newc...
src/js/promise.js:319: return;
On 2016/10/27 08:02:34, adamk wrote:
> No need for this empty return

Done.

https://codereview.chromium.org/2451163003/diff/140001/src/runtime/runtime-in...
File src/runtime/runtime-internal.cc (right):

https://codereview.chromium.org/2451163003/diff/140001/src/runtime/runtime-in...
src/runtime/runtime-internal.cc:302:
isolate->ReportPromiseReject(Handle<JSObject>::cast(promise), value,
On 2016/10/27 08:02:34, adamk wrote:
> Why is this safe? Or rather, why did the promise argument change to a
> JSReceiver?

Changed back to JSObject

[adamk, 2016-10-27 11:28:45]

lgtm

[commit-bot: I haz the power, 2016-10-27 11:49:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 11:49:38]

Dry run: This issue passed the CQ dry run.

[gsathya, 2016-10-27 11:49:49]

The CQ bit was checked by gsathya@chromium.org

[commit-bot: I haz the power, 2016-10-27 11:49:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 11:51:40]

Description was changed from

==========
[promises] Move PromiseReject to c++

This patch refactors most of FulfillPromise runtime call out to a separate 
function so that we can to it from PromiseReject runtime call.

This patch adds a PromiseStatus enum.

BUG=v8:5343
==========

to

==========
[promises] Move PromiseReject to c++

This patch refactors most of FulfillPromise runtime call out to a separate 
function so that we can to it from PromiseReject runtime call.

This patch adds a PromiseStatus enum.

BUG=v8:5343
==========

[commit-bot: I haz the power, 2016-10-27 11:51:41]

Committed patchset #9 (id:160001)

[Camillo Bruni, 2016-10-30 15:49:11]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2460213002/ by cbruni@chromium.org.

The reason for reverting is: Causes parse and compile regressions on yahoo and
ebay (cbrug/660720)..

[commit-bot: I haz the power, 2016-11-17 22:15:15]

Description was changed from

==========
[promises] Move PromiseReject to c++

This patch refactors most of FulfillPromise runtime call out to a separate 
function so that we can to it from PromiseReject runtime call.

This patch adds a PromiseStatus enum.

BUG=v8:5343
==========

to

==========
[promises] Move PromiseReject to c++

This patch refactors most of FulfillPromise runtime call out to a separate
function so that we can to it from PromiseReject runtime call.

This patch adds a PromiseStatus enum.

BUG=v8:5343

Committed: https://crrev.com/f80f450993f926e6b4cd2d4b0bbf9c931bb199a1
Cr-Commit-Position: refs/heads/master@{#40615}
==========

[commit-bot: I haz the power, 2016-11-17 22:15:17]

Patchset 9 (id:??) landed as
https://crrev.com/f80f450993f926e6b4cd2d4b0bbf9c931bb199a1
Cr-Commit-Position: refs/heads/master@{#40615}