Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2451163002: Add missing break; to switch statement in safe_browsing::GetListName. (Closed)

Created:
4 years, 1 month ago by grt (UTC plus 2)
Modified:
4 years, 1 month ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, vakh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing break; to switch statement in safe_browsing::GetListName. R=nparker@chromium.org BUG= Committed: https://crrev.com/006ed6319df0d4aab65d593650b6969d925a168f Cr-Commit-Position: refs/heads/master@{#427739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/safe_browsing_db/util.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
grt (UTC plus 2)
PTAL. Feel free to check the CQ box if this looks good to you. Thanks.
4 years, 1 month ago (2016-10-26 11:42:53 UTC) #3
Nathan Parker
lgtm huh, this isn't called anywhere besides tests, ya? Otherwise, this would probably really break ...
4 years, 1 month ago (2016-10-26 17:40:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451163002/1
4 years, 1 month ago (2016-10-26 17:41:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 17:46:23 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 17:51:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/006ed6319df0d4aab65d593650b6969d925a168f
Cr-Commit-Position: refs/heads/master@{#427739}

Powered by Google App Engine
This is Rietveld 408576698