Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: src/objects.h

Issue 2451153002: [modules] Improve error messages. (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index ef3f31df4793aefb3cdfbc7012a9c889589b8fb7..d1da1687f573aa06b502ab58c8c731ef7708c3f7 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -4740,11 +4740,14 @@ class ModuleInfoEntry : public FixedArray {
Handle<Object> export_name,
Handle<Object> local_name,
Handle<Object> import_name,
- Handle<Object> module_request);
+ Handle<Object> module_request,
+ int beg_pos, int end_pos);
inline Object* export_name() const;
inline Object* local_name() const;
inline Object* import_name() const;
inline Object* module_request() const;
+ inline int beg_pos() const;
+ inline int end_pos() const;
private:
friend class Factory;
@@ -4753,6 +4756,8 @@ class ModuleInfoEntry : public FixedArray {
kLocalNameIndex,
kImportNameIndex,
kModuleRequestIndex,
+ kBegPosIndex,
+ kEndPosIndex,
kLength
};
};
@@ -8223,16 +8228,16 @@ class Module : public Struct {
// exception (so check manually!).
class ResolveSet;
static MUST_USE_RESULT MaybeHandle<Cell> ResolveExport(
- Handle<Module> module, Handle<String> name, bool must_resolve,
- ResolveSet* resolve_set);
+ Handle<Module> module, Handle<String> name, MessageLocation loc,
+ bool must_resolve, ResolveSet* resolve_set);
static MUST_USE_RESULT MaybeHandle<Cell> ResolveImport(
Handle<Module> module, Handle<String> name, int module_request,
- bool must_resolve, ResolveSet* resolve_set);
+ MessageLocation loc, bool must_resolve, ResolveSet* resolve_set);
// Helper for ResolveExport.
static MUST_USE_RESULT MaybeHandle<Cell> ResolveExportUsingStarExports(
- Handle<Module> module, Handle<String> name, bool must_resolve,
- ResolveSet* resolve_set);
+ Handle<Module> module, Handle<String> name, MessageLocation loc,
+ bool must_resolve, ResolveSet* resolve_set);
DISALLOW_IMPLICIT_CONSTRUCTORS(Module);
};

Powered by Google App Engine
This is Rietveld 408576698