Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2451143003: <webview>: Correctly shift focus between WebContents. (Closed)
Patch Set: Address wjmaclean comment: ternary op. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index c9e3649b0621769ed721702b16df5913fc23d2ab..bfa64b8889144c539495109c799385bf18faa460 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -654,6 +654,8 @@ class CONTENT_EXPORT WebContentsImpl
void ReplicatePageFocus(bool is_focused) override;
RenderWidgetHostImpl* GetFocusedRenderWidgetHost(
RenderWidgetHostImpl* receiving_widget) override;
+ void EnsureOwningContentsIsFocused(
+ RenderWidgetHostImpl* render_widget_host) override;
void RendererUnresponsive(RenderWidgetHostImpl* render_widget_host,
RendererUnresponsiveType type) override;
void RendererResponsive(RenderWidgetHostImpl* render_widget_host) override;
@@ -1017,6 +1019,10 @@ class CONTENT_EXPORT WebContentsImpl
// Returns the root of the WebContents tree.
WebContentsImpl* GetOutermostWebContents();
+ // Become the focused WebContentsImpl. This will activate this content's
+ // RenderWidget and direct keyboard input to it.
alexmos 2016/10/28 06:36:39 I'd also mention what happens to |old_contents|.
avallee 2016/10/28 19:19:57 Done.
+ void ChangeFocus(WebContentsImpl* old_contents);
+
// Navigation helpers --------------------------------------------------------
//
// These functions are helpers for Navigate() and DidNavigate().

Powered by Google App Engine
This is Rietveld 408576698