Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: content/browser/frame_host/frame_tree.cc

Issue 2451143003: <webview>: Correctly shift focus between WebContents. (Closed)
Patch Set: Fix creis comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/frame_tree.cc
diff --git a/content/browser/frame_host/frame_tree.cc b/content/browser/frame_host/frame_tree.cc
index b51cee42ad2b89ec8358903d699dce0f512aa46a..48bc7137a28d3d1ac05ad886dad4fc2da386a0a0 100644
--- a/content/browser/frame_host/frame_tree.cc
+++ b/content/browser/frame_host/frame_tree.cc
@@ -264,18 +264,6 @@ void FrameTree::SetFocusedFrame(FrameTreeNode* node, SiteInstance* source) {
if (node == GetFocusedFrame())
return;
- if (!node) {
- // TODO(avallee): https://crbug.com/614463 Notify proxies here once
- // <webview> supports oopifs inside itself.
- if (GetFocusedFrame())
- GetFocusedFrame()->current_frame_host()->ClearFocusedFrame();
- focused_frame_tree_node_id_ = FrameTreeNode::kFrameTreeNodeInvalidId;
-
- // TODO(avallee): https://crbug.com/610795 This line is not sufficient to
- // make the test pass. There seems to be no focus change events generated.
- root()->current_frame_host()->UpdateAXTreeData();
- return;
- }
std::set<SiteInstance*> frame_tree_site_instances =
CollectSiteInstances(this);

Powered by Google App Engine
This is Rietveld 408576698