Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 2451143003: <webview>: Correctly shift focus between WebContents. (Closed)
Patch Set: Address comments from alexmos and lfg. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 243
244 // Indicates whether the RenderWidgetHost thinks it is focused. 244 // Indicates whether the RenderWidgetHost thinks it is focused.
245 // This is different from RenderWidgetHostView::HasFocus() in the sense that 245 // This is different from RenderWidgetHostView::HasFocus() in the sense that
246 // it reflects what the renderer process knows: it saves the state that is 246 // it reflects what the renderer process knows: it saves the state that is
247 // sent/received. 247 // sent/received.
248 // RenderWidgetHostView::HasFocus() is checking whether the view is focused so 248 // RenderWidgetHostView::HasFocus() is checking whether the view is focused so
249 // it is possible in some edge cases that a view was requested to be focused 249 // it is possible in some edge cases that a view was requested to be focused
250 // but it failed, thus HasFocus() returns false. 250 // but it failed, thus HasFocus() returns false.
251 bool is_focused() const { return is_focused_; } 251 bool is_focused() const { return is_focused_; }
252 252
253 // Support for focus tracking on multi-WebContents cases. Users other than
alexmos 2016/10/31 18:57:57 Let's explain more carefully what this does. I.e.
avallee 2016/11/07 19:18:44 Done.
254 // WebContens and RenderWidgetHost should use Focus()/Blur().
255 void SetPageFocus(bool focused);
256
253 // Called to notify the RenderWidget that it has lost the mouse lock. 257 // Called to notify the RenderWidget that it has lost the mouse lock.
254 void LostMouseLock(); 258 void LostMouseLock();
255 259
256 // Notifies the RenderWidget that it lost the mouse lock. 260 // Notifies the RenderWidget that it lost the mouse lock.
257 void SendMouseLockLost(); 261 void SendMouseLockLost();
258 262
259 // Noifies the RenderWidget of the current mouse cursor visibility state. 263 // Noifies the RenderWidget of the current mouse cursor visibility state.
260 void SendCursorVisibilityState(bool is_visible); 264 void SendCursorVisibilityState(bool is_visible);
261 265
262 // Notifies the RenderWidgetHost that the View was destroyed. 266 // Notifies the RenderWidgetHost that the View was destroyed.
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
862 #endif 866 #endif
863 867
864 base::WeakPtrFactory<RenderWidgetHostImpl> weak_factory_; 868 base::WeakPtrFactory<RenderWidgetHostImpl> weak_factory_;
865 869
866 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl); 870 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl);
867 }; 871 };
868 872
869 } // namespace content 873 } // namespace content
870 874
871 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 875 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698