Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Unified Diff: pkg/analysis_server/lib/src/domain_server.dart

Issue 245113006: Consistently type check analysis server request parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/domain_server.dart
diff --git a/pkg/analysis_server/lib/src/domain_server.dart b/pkg/analysis_server/lib/src/domain_server.dart
index 7b983f8044e0edac42869affb3fa39136d2e5712..102a79c2f77e2ade4812d8ba1d411ec4479273c0 100644
--- a/pkg/analysis_server/lib/src/domain_server.dart
+++ b/pkg/analysis_server/lib/src/domain_server.dart
@@ -92,10 +92,10 @@ class ServerDomainHandler implements RequestHandler {
* Clients, therefore, are responsible for managing the lifetime of contexts.
*/
Response createContext(Request request) {
- String sdkDirectory = request.getRequiredParameter(SDK_DIRECTORY_PARAM);
- Map<String, String> packageMap = request.getParameter(PACKAGE_MAP_PARAM);
+ String sdkDirectory = request.getRequiredParameter(SDK_DIRECTORY_PARAM).asString();
+ Map<String, String> packageMap = request.getParameter(PACKAGE_MAP_PARAM, {}).asStringMap();
- String contextId = request.getRequiredParameter(CONTEXT_ID_PARAM);
+ String contextId = request.getRequiredParameter(CONTEXT_ID_PARAM).asString();
if (server.contextMap.containsKey(contextId)) {
return new Response.contextAlreadyExists(request);
}
@@ -126,7 +126,7 @@ class ServerDomainHandler implements RequestHandler {
* will result in an error being returned.
*/
Response deleteContext(Request request) {
- String contextId = request.getRequiredParameter(CONTEXT_ID_PARAM);
+ String contextId = request.getRequiredParameter(CONTEXT_ID_PARAM).asString();
AnalysisContext removedContext = server.contextMap.remove(contextId);
if (removedContext == null) {

Powered by Google App Engine
This is Rietveld 408576698