Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2932)

Unified Diff: base/win/scoped_comptr.h

Issue 2451123004: WIP - allow scoped_refptr to be used without full defn of T (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/memory/ref_counted.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/scoped_comptr.h
diff --git a/base/win/scoped_comptr.h b/base/win/scoped_comptr.h
index 5ce60e2b688f603b2b681e42a270e41e6156f704..57c8d836f02c9750103f5814e3fbad225cf90f8a 100644
--- a/base/win/scoped_comptr.h
+++ b/base/win/scoped_comptr.h
@@ -54,7 +54,8 @@ class ScopedComPtr : public scoped_refptr<Interface> {
// be confused with e.g. scoped_ptr::release().
void Release() {
if (this->ptr_ != NULL) {
- this->ptr_->Release();
+ //FIXME: need to null |ref_| in this class as well.
+ this->ref_->Release();
this->ptr_ = NULL;
}
}
« no previous file with comments | « base/memory/ref_counted.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698