Make NGLayoutOpportunityIterator to support origin_point.

Make NGLayoutOpportunityIterator to support origin_point.

Origin point is used to filter layout opportunities that are positioned before the origin point.

BUG=635619
Committed: https://crrev.com/25499c90fd4d12a36436ba75a3260008a30c7c71
Cr-Commit-Position: refs/heads/master@{#428439}

[Gleb Lanbin, 2016-10-26 22:20:47]

Patchset #1 (id:1) has been deleted

[Gleb Lanbin, 2016-10-26 22:20:53]

Patchset #2 (id:40001) has been deleted

[Gleb Lanbin, 2016-10-26 22:21:28]

Patchset #1 (id:20001) has been deleted

[Gleb Lanbin, 2016-10-26 22:22:55]

glebl@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[Gleb Lanbin, 2016-10-26 23:14:13]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 23:14:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 00:22:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 00:22:57]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Gleb Lanbin, 2016-10-27 02:01:13]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 02:01:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 02:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 02:09:54]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Gleb Lanbin, 2016-10-27 06:30:00]

Patchset #2 (id:80001) has been deleted

[Gleb Lanbin, 2016-10-27 06:30:09]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 06:30:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 08:00:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 08:00:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Gleb Lanbin, 2016-10-27 19:53:14]

please hold on on review. The current approach where origin point is used as a
filter is not correct.

[Gleb Lanbin, 2016-10-27 22:16:57]

Patchset #1 (id:60001) has been deleted

[Gleb Lanbin, 2016-10-27 22:17:05]

Patchset #1 (id:100001) has been deleted

[Gleb Lanbin, 2016-10-27 22:18:37]

updated with the correct implementation. please review when you have a chance.

[ikilpatrick, 2016-10-28 16:39:28]

lgtm

https://codereview.chromium.org/2451123003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
(right):

https://codereview.chromium.org/2451123003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc:185:
TEST(NGConstraintSpaceTest, LayoutOpportunitiesTwoInMiddleWithOrigin) {
\o/

[Gleb Lanbin, 2016-10-28 16:45:25]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 16:45:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 18:04:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 18:04:27]

Dry run: This issue passed the CQ dry run.

[Gleb Lanbin, 2016-10-28 18:34:38]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2016-10-28 18:35:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 18:42:13]

Committed patchset #1 (id:120001)

[commit-bot: I haz the power, 2016-10-28 19:09:02]

Description was changed from

==========
Make NGLayoutOpportunityIterator to support origin_point.

Origin point is used to filter layout opportunities that are positioned before
the origin point.

BUG=635619
==========

to

==========
Make NGLayoutOpportunityIterator to support origin_point.

Origin point is used to filter layout opportunities that are positioned before
the origin point.

BUG=635619

Committed: https://crrev.com/25499c90fd4d12a36436ba75a3260008a30c7c71
Cr-Commit-Position: refs/heads/master@{#428439}
==========

[commit-bot: I haz the power, 2016-10-28 19:09:04]

Patchset 1 (id:??) landed as
https://crrev.com/25499c90fd4d12a36436ba75a3260008a30c7c71
Cr-Commit-Position: refs/heads/master@{#428439}