Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2451123002: Revert of Roll src/third_party/skia/ 18b61f9cb..f2361d2d9 (2 commits). (Closed)

Created:
4 years, 1 month ago by foolip
Modified:
4 years, 1 month ago
Reviewers:
skia-deps-roller, reed1
CC:
chromium-reviews, reed1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll src/third_party/skia/ 18b61f9cb..f2361d2d9 (2 commits). (patchset #1 id:1 of https://codereview.chromium.org/2449343002/ ) Reason for revert: Failing assert in newly added file on Win 7 Dbg: https://bugs.chromium.org/p/chromium/issues/detail?id=624233#c18 Original issue's description: > Roll src/third_party/skia/ 18b61f9cb..f2361d2d9 (2 commits). > > https://chromium.googlesource.com/skia.git/+log/18b61f9cb9d0..f2361d2d93c2 > > $ git log 18b61f9cb..f2361d2d9 --date=short --no-merges --format='%ad %ae %s' > 2016-10-25 robertphillips Add GrOpList and rename GrDrawTarget to GrRenderTargetOpList > 2016-10-25 brianosman GrConstColorProcessor uses 4f colors in the destination space > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, see: > http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > TBR=reed@google.com > > Committed: https://crrev.com/b2c90584603144031e89c697aefb34ea201c83da > Cr-Commit-Position: refs/heads/master@{#427601} TBR=reed@google.com,skia-deps-roller@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/5d00f6b224c8cc68ec10d1d9d0ef6735ddfda16f Cr-Commit-Position: refs/heads/master@{#427654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
foolip
Created Revert of Roll src/third_party/skia/ 18b61f9cb..f2361d2d9 (2 commits).
4 years, 1 month ago (2016-10-26 10:00:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451123002/1
4 years, 1 month ago (2016-10-26 10:00:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 10:01:27 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5d00f6b224c8cc68ec10d1d9d0ef6735ddfda16f Cr-Commit-Position: refs/heads/master@{#427654}
4 years, 1 month ago (2016-10-26 10:03:39 UTC) #7
foolip
4 years, 1 month ago (2016-10-26 14:18:37 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2448193003/ by foolip@chromium.org.

The reason for reverting is: Wrong roll was reverted, failing assert was
introduced several rolls earlier:
https://codereview.chromium.org/2447033003.

Powered by Google App Engine
This is Rietveld 408576698