Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: media/base/simd/scale_yuv_to_rgb_mmx.inc

Issue 245103003: Remove non-PIC specializations of media SIMD YUV conversion routines. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@m
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/simd/linear_scale_yuv_to_rgb_mmx.inc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/simd/scale_yuv_to_rgb_mmx.inc
diff --git a/media/base/simd/scale_yuv_to_rgb_mmx.inc b/media/base/simd/scale_yuv_to_rgb_mmx.inc
index 2026390ed00bcc27033d0543af6f55ffaf7642a0..a599b0c30a2262569ec0480e2acf9cb4935739ea 100644
--- a/media/base/simd/scale_yuv_to_rgb_mmx.inc
+++ b/media/base/simd/scale_yuv_to_rgb_mmx.inc
@@ -28,34 +28,21 @@ PROLOGUE 6, 7, 3, Y, U, V, ARGB, R1, R2, TEMP
%define WORD_SIZE DWORD
%endif
-%ifdef PIC
PUSH R1q ; Width
-%endif
PUSH R2q ; Source dx
%define SOURCE_DX WORD_SIZE [rsp]
-; PIC code.
-%ifdef PIC
LOAD_SYM R1q, mangle(kCoefficientsRgbY)
%define WIDTH WORD_SIZE [rsp + gprsize]
%define TABLE R1q
%define Xq R2q
-; Non-PIC code.
-%else
-%define WIDTH R1q
-%define TABLE mangle(kCoefficientsRgbY)
-%define Xq R2q
-%endif
-
; Set Xq index to 0.
xor Xq, Xq
jmp .scaleend
.scaleloop:
- ; TABLE can either be a register or a symbol depending on this is
- ; PIC or not.
mov TEMPq, Xq
sar TEMPq, 17
movzx TEMPd, BYTE [Uq + TEMPq]
@@ -83,8 +70,6 @@ PROLOGUE 6, 7, 3, Y, U, V, ARGB, R1, R2, TEMP
add ARGBq, 8
.scaleend:
- ; WIDTH can either be a register or memory depending on this is
- ; PIC or not.
sub WIDTH, 2
jns .scaleloop
@@ -109,9 +94,5 @@ PROLOGUE 6, 7, 3, Y, U, V, ARGB, R1, R2, TEMP
movd DWORD [ARGBq], mm1
.scaledone:
-%ifdef PIC
ADD rsp, 2 * gprsize
-%else
- ADD rsp, gprsize
-%endif
RET
« no previous file with comments | « media/base/simd/linear_scale_yuv_to_rgb_mmx.inc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698