chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc - Issue 2450993003: Componentize safe_browsing [1]: create component, move messages, constants and switches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

Issue 2450993003: Componentize safe_browsing [1]: create component, move messages, constants and switches. (Closed)

Patch Set: rebase + more fixes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/BUILD.gn ('K') | « chrome/renderer/safe_browsing/phishing_classifier_delegate.cc ('k') | chrome/renderer/safe_browsing/threat_dom_details.cc » ('j') | components/safe_browsing/common/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc b/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

index 67ced46ece4867661af0f2225f1472c662ccb194..5e5b799cb471bc0692031fabd65ca5e7bbbbf2ef 100644

--- a/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

+++ b/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

@@ -8,12 +8,12 @@

#include "base/strings/utf_string_conversions.h"

#include "chrome/common/safe_browsing/csd.pb.h"

-#include "chrome/common/safe_browsing/safebrowsing_messages.h"

#include "chrome/renderer/safe_browsing/features.h"

#include "chrome/renderer/safe_browsing/phishing_classifier.h"

#include "chrome/renderer/safe_browsing/scorer.h"

#include "chrome/test/base/chrome_render_view_test.h"

#include "chrome/test/base/chrome_unit_test_suite.h"

+#include "components/safe_browsing/common/safebrowsing_messages.h"

#include "content/public/renderer/render_frame.h"

#include "content/public/renderer/render_view.h"

#include "testing/gmock/include/gmock/gmock.h"