chrome/browser/safe_browsing/download_protection_service_unittest.cc - Issue 2450993003: Componentize safe_browsing [1]: create component, move messages, constants and switches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_protection_service_unittest.cc

Issue 2450993003: Componentize safe_browsing [1]: create component, move messages, constants and switches. (Closed)

Patch Set: rebase + more fixes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service.cc ('k') | chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc » ('j') | chrome/renderer/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_protection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/download_protection_service_unittest.cc b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

index 3beab5636a5ce3808c5ec574d402cef4ee565bb7..dd6e2acd518bcae7e23c15d3969ce441b722d5dc 100644

--- a/chrome/browser/safe_browsing/download_protection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

@@ -33,13 +33,13 @@

#include "chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h"

#include "chrome/browser/safe_browsing/local_database_manager.h"

#include "chrome/browser/safe_browsing/safe_browsing_service.h"

-#include "chrome/common/chrome_switches.h"

#include "chrome/common/safe_browsing/binary_feature_extractor.h"

#include "chrome/common/safe_browsing/csd.pb.h"

#include "chrome/common/safe_browsing/file_type_policies_test_util.h"

#include "chrome/test/base/testing_profile.h"

#include "components/history/core/browser/history_service.h"

#include "components/prefs/pref_service.h"

+#include "components/safe_browsing/common/safebrowsing_switches.h"

#include "components/safe_browsing_db/database_manager.h"

#include "components/safe_browsing_db/safe_browsing_prefs.h"

#include "components/safe_browsing_db/test_database_manager.h"

@@ -2300,7 +2300,7 @@ class DownloadProtectionServiceFlagTest : public DownloadProtectionServiceTest {

blacklisted_hash_ = std::string(bytes.begin(), bytes.end());

base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(

- switches::kSbManualDownloadBlacklist,

+ safe_browsing::switches::kSbManualDownloadBlacklist,

blacklisted_hash_hex_);

DownloadProtectionServiceTest::SetUp();