components/safe_browsing/common/safebrowsing_switches.h - Issue 2450993003: Componentize safe_browsing [1]: create component, move messages, constants and switches.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/safe_browsing/common/safebrowsing_switches.h

Issue 2450993003: Componentize safe_browsing [1]: create component, move messages, constants and switches. (Closed)

Patch Set: address Nathan's comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_SAFE_BROWSING_COMMON_SAFEBROWSING_SWITCHES_H_

	6 #define COMPONENTS_SAFE_BROWSING_COMMON_SAFEBROWSING_SWITCHES_H_

	7

	8 namespace safe_browsing {

	9 namespace switches {

	10

	11 extern const char kSbDisableAutoUpdate[];
	Nathan Parker 2016/11/10 18:57:46 FYI none of these switches are relevant to WebView FYI none of these switches are relevant to WebView -- they will only be used by chrome. Is there a need to move them? timvolodine 2016/11/18 14:07:11 kSbDisableAutoUpdate is used in safe_browsing_serv Show quoted text On 2016/11/10 18:57:46, Nathan Parker wrote: > FYI none of these switches are relevant to WebView -- they will only be used by > chrome. Is there a need to move them? kSbDisableAutoUpdate is used in safe_browsing_service.cc so need to move it out. it's possible other switches may not necessarily need moving, however it's good to have them in one place for component's sake.
	12 extern const char kSbDisableDownloadProtection[];

	13 extern const char kSbDisableExtensionBlacklist[];

	14 extern const char kSbManualDownloadBlacklist[];

	15

	16 } // namespace switches

	17 } // namespace safe_browsing

	18

	19 #endif // COMPONENTS_SAFE_BROWSING_COMMON_SAFEBROWSING_SWITCHES_H_

OLD	NEW