components/safe_browsing/common/safebrowsing_constants.cc - Issue 2450993003: Componentize safe_browsing [1]: create component, move messages, constants and switches.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/safe_browsing/common/safebrowsing_constants.cc

Issue 2450993003: Componentize safe_browsing [1]: create component, move messages, constants and switches. (Closed)

Patch Set: address Nathan's comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/safe_browsing/common/safebrowsing_constants.h ('k') | components/safe_browsing/common/safebrowsing_message_generator.h » ('j') | components/safe_browsing/common/safebrowsing_switches.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/safe_browsing/common/safebrowsing_constants.h"

	6

	7 namespace safe_browsing {

	8

	9 const base::FilePath::CharType kSafeBrowsingBaseFilename[] =

	10 FILE_PATH_LITERAL("Safe Browsing");
	Nathan Parker 2016/11/10 18:57:46 This won't be needed by WebView directly. If it's This won't be needed by WebView directly. If it's easier to move some of these rather than disentangle them, that's probably ok, but it would be cleaner to leave the embedder data (file paths, switches) in /chrome/. timvolodine 2016/11/18 14:07:11 safe_browsing_service uses that constant, and we'l Show quoted text On 2016/11/10 18:57:46, Nathan Parker wrote: > This won't be needed by WebView directly. If it's easier to move some of these > rather than disentangle them, that's probably ok, but it would be cleaner to > leave the embedder data (file paths, switches) in /chrome/. safe_browsing_service uses that constant, and we'll need to move that file to component as well because safe_browsing_resource_throttle depends on it. Nathan Parker 2016/11/18 17:30:03 Digging into this, it's used by the SafeBrowisingS Show quoted text On 2016/11/18 14:07:11, timvolodine wrote: > On 2016/11/10 18:57:46, Nathan Parker wrote: > > This won't be needed by WebView directly. If it's easier to move some of > these > > rather than disentangle them, that's probably ok, but it would be cleaner to > > leave the embedder data (file paths, switches) in /chrome/. > > safe_browsing_service uses that constant, and we'll need to move that file to > component as well because safe_browsing_resource_throttle depends on it. Digging into this, it's used by the SafeBrowisingServiceImpl (which I assume does not need componentizing), but then also by the safe_browsing_cookie_store. The latter _may_ be used by the PingManager (which does need moving). Some safe browsing code that shares that safe_browsing_request_context doesn't set cookies so it wouldn't need this, but we can tease that apart another time. I think this is fine.
	11

	12 } // namespace safe_browsing

OLD	NEW