components/safe_browsing/common/safebrowsing_message_generator.h - Issue 2450993003: Componentize safe_browsing [1]: create component, move messages, constants and switches.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/safe_browsing/common/safebrowsing_message_generator.h

Issue 2450993003: Componentize safe_browsing [1]: create component, move messages, constants and switches. (Closed)

Patch Set: rebase + more fixes Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be
	Nathan Parker 2016/10/28 17:55:07 Do we need this file at all? Could refs to it jus Do we need this file at all? Could refs to it just use the component .h? I'm not familiar with how this one is used. timvolodine 2016/11/04 17:53:02 yes for components we usually have own generators, Show quoted text On 2016/10/28 17:55:07, Nathan Parker wrote: > Do we need this file at all? Could refs to it just use the component .h? I'm > not familiar with how this one is used. yes for components we usually have own generators, this is needed because we are moving the messages out of chrome/common/common_message_generator.h
3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included file, hence no include guard.	5 // Multiply-included file, hence no include guard.

6	6

7 #include "build/build_config.h"	7 #include "components/safe_browsing/common/safebrowsing_messages.h"

8 #include "gpu/ipc/common/gpu_messages.h"

OLD	NEW