components/safe_browsing/common/BUILD.gn - Issue 2450993003: Componentize safe_browsing [1]: create component, move messages, constants and switches.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/safe_browsing/common/BUILD.gn

Issue 2450993003: Componentize safe_browsing [1]: create component, move messages, constants and switches. (Closed)

Patch Set: rebase + more fixes Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("common") {
	Nathan Parker 2016/10/28 17:55:07 Can you comment on what will use this source set? Can you comment on what will use this source set? Is it all platforms that use any part of SB? timvolodine 2016/11/04 17:53:02 yes currently all who use the files listed, in the Show quoted text On 2016/10/28 17:55:07, Nathan Parker wrote: > Can you comment on what will use this source set? Is it all platforms that use > any part of SB? yes currently all who use the files listed, in the future more 'common' files can go here
	6 sources = [

	7 "safebrowsing_constants.cc",

	8 "safebrowsing_constants.h",

	9 "safebrowsing_message_generator.cc",

	10 "safebrowsing_message_generator.h",

	11 "safebrowsing_messages.h",

	12 "safebrowsing_switches.cc",

	13 "safebrowsing_switches.h",

	14 ]

	15

	16 deps = [

	17 "//base",

	18 "//ipc",

	19 "//url/ipc:url_ipc",

	20 ]

	21 }

OLD	NEW