Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2450943005: Convert editing/spelling/paste_into_element_starting_with_invisible.html with spellcheck_test (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/spelling/paste_into_element_starting_with_invisible.html with spellcheck_test This patch converts the above mentioned layout test with spellcheck_test as a preparation of implementing idle time spellchecker. BUG=517298 Committed: https://crrev.com/5340dfc51002cb473e34210e521e9fd45ad76e30 Cr-Commit-Position: refs/heads/master@{#427616}

Patch Set 1 #

Patch Set 2 : Remove garbage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/paste_into_element_starting_with_invisible.html View 1 1 chunk +19 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Xiaocheng
PTAL.
4 years, 1 month ago (2016-10-26 05:54:35 UTC) #6
yosin_UTC9
lgtm
4 years, 1 month ago (2016-10-26 06:20:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450943005/20001
4 years, 1 month ago (2016-10-26 06:20:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 06:46:21 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 06:48:42 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5340dfc51002cb473e34210e521e9fd45ad76e30
Cr-Commit-Position: refs/heads/master@{#427616}

Powered by Google App Engine
This is Rietveld 408576698