Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1234)

Issue 2450943002: GIF: Fill the frame if we have a dummy color table (Closed)

Created:
4 years, 1 month ago by scroggo_chromium
Modified:
4 years, 1 month ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GIF: Fill the frame if we have a dummy color table Since we will not draw anything later, we need to fill the frame with the fill color. NOTREECHECKS=true BUG=skia:5883 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2450943002 Committed: https://skia.googlesource.com/skia/+/8bce117ff770f4778f496911b83f953a53907ed4

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/codec/SkGifCodec.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
scroggo_chromium
4 years, 1 month ago (2016-10-25 19:31:43 UTC) #3
msarett
lgtm
4 years, 1 month ago (2016-10-25 19:33:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450943002/1
4 years, 1 month ago (2016-10-25 19:34:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450943002/1
4 years, 1 month ago (2016-10-25 19:42:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450943002/20001
4 years, 1 month ago (2016-10-25 19:47:37 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 20:08:42 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8bce117ff770f4778f496911b83f953a53907ed4

Powered by Google App Engine
This is Rietveld 408576698